chore(deps): update unmaintained dependency from kuchiki to kuchikiki - #7359
Merged
Conversation
Member
|
that's awesome! was waiting for someone to fork it and seeing a fork from a pretty big project is really nice to see 🥳 |
amrbashir
requested changes
Jul 5, 2023
davide-baldo
force-pushed
the
kuchiki-to-kuchikiki
branch
from
July 5, 2023 15:43
ccdee74 to
7630126
Compare
…, a fork maintened by brave tauri-apps#6123 tauri-apps#6411
amrbashir
previously approved these changes
Jul 5, 2023
amrbashir
left a comment
amrbashir
left a comment
Member
There was a problem hiding this comment.
LGTM! but I will leave this one for @lucasfernog to merge
lucasfernog
approved these changes
Jul 5, 2023
lucasfernog
added a commit
that referenced
this pull request
Jul 5, 2023
…#7359) Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Kuchiki is an unmainted dependency, closes #6123 , closes #6411
Brave adopted kuchiki, renaming it to kuchikiki, this PR switched from kuchiki to kuchikiki and update html5ever to version 0.26 to align the 2 versions.
Does this PR introduce a breaking change?
No - As far I understand.
Checklist
fix: remove a typo, closes #___, #___)Other information
Using an unmaintained dependency is risky as it allows for vulnerabilities to slip through old cracks, it also block upgrading other packages (
html5everin this case). It should be addressed as quickly as possible, since the price to migrate only increases over time.