Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler/nsis): fix error message appears even after successful uninstall, closes #7317 #7361

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

luoffei
Copy link
Contributor

@luoffei luoffei commented Jul 5, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir linked an issue Jul 5, 2023 that may be closed by this pull request
@amrbashir
Copy link
Member

Thank you

@amrbashir
Copy link
Member

@luoffei Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example.

@luoffei
Copy link
Contributor Author

luoffei commented Jul 6, 2023

@luoffei Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example.

done.

@amrbashir amrbashir changed the title fix(bundler/nsis): an error message appears when the uninstallation is successful. closes #7317 fix(bundler/nsis): fix error message appears even after successful uninstall, closes #7317 Jul 8, 2023
@amrbashir amrbashir merged commit 0ae53f4 into tauri-apps:1.x Jul 8, 2023
@luoffei luoffei deleted the fix7317 branch July 8, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

[bug] windows NSIS uninstaller issue with tauri-cli 1.4.0
2 participants