Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundler/nsis): fix installer incorrect copyright info #7386

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix(bundler/nsis): fix installer incorrect copyright info #7386

merged 1 commit into from
Jul 10, 2023

Conversation

luoffei
Copy link
Contributor

@luoffei luoffei commented Jul 9, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

image

@luoffei
fix(bundler/nsis): copyright information display error
a44f33f 
Signed-off-by: luofei <luoffei@outlook.com>
@luoffei luoffei requested a review from a team as a code owner July 9, 2023 02:07
@wusyong wusyong added the status: needs review A maintainer must review this code label Jul 10, 2023
amrbashir
amrbashir approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir amrbashir changed the title fix(bundler/nsis): copyright information display error fix(bundler/nsis): fix installer incorrect copyright info Jul 10, 2023
@amrbashir amrbashir merged commit eba8e13 into tauri-apps:1.x Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
status: needs review A maintainer must review this code
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luoffei @amrbashir @wusyong