Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api/http): properly handle Files in Body.form, closes #7390 #7394

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner July 10, 2023 17:41
@wusyong wusyong added the status: needs review A maintainer must review this code label Jul 11, 2023
@lucasfernog
Copy link
Member

@amrbashir what do you think about my last commit? Seems like using a File will usually require us to read the bytes anyway, so it doesn't make much sense to have two separate functions.

@amrbashir
Copy link
Member Author

yeah looks better than my solution, I will update the change log

@lucasfernog lucasfernog changed the title feat(api/http): add Body.formAsync, closes #7390 feat(api/http): properly handle Files in Body.form, closes #7390 Jul 12, 2023
@lucasfernog lucasfernog merged commit 2eab150 into 1.x Jul 13, 2023
@lucasfernog lucasfernog deleted the feat/api/Body-formAsync branch July 13, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review A maintainer must review this code
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

3 participants