feat(api/http): properly handle Files in Body.form, closes #7390#7394
Merged
lucasfernog merged 7 commits into1.xfrom Jul 13, 2023
Merged
feat(api/http): properly handle Files in Body.form, closes #7390#7394lucasfernog merged 7 commits into1.xfrom
lucasfernog merged 7 commits into1.xfrom
Conversation
Member
|
@amrbashir what do you think about my last commit? Seems like using a File will usually require us to read the bytes anyway, so it doesn't make much sense to have two separate functions. |
Member
Author
|
yeah looks better than my solution, I will update the change log |
Body.formAsync, closes #7390
lucasfernog
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information