feat(bundler/nsis): sign uninstaller, closes #7348

[amrbashir]

What kind of change does this PR introduce?

• Bugfix
• Feature
• Docs
• New Binding issue #___
• Code style update
• Refactor
• Build-related changes
• Other, please describe:

Does this PR introduce a breaking change?

• Yes, and the changes were approved in issue #___
• No

Checklist

• When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
• A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
• I have added a convincing reason for adding this feature, if necessary

Other information

[amrbashir]

This is not tested yet, so I will convert to a draft

[amrbashir]

I am having a bit of a hard time trying to generate a signing certificate to test. @FabianLars if you have one, could you test this PR?

[FabianLars]

So, according to the logs all went well:

Finished dev [unoptimized + debuginfo] target(s) in 1m 21s
        Info Target: x64
     Signing C:\Users\Fabian-Lars\dev\_target\debug\tauri-app2.exe
     Signing C:\Users\Fabian-Lars\dev\_target\debug\tauri-app2.exe with identity "88FB696BE8176B9668F55E027D5AD83027495749"
        Info "Done Adding Additional Store\r\nSuccessfully signed: C:\\Users\\Fabian-Lars\\dev\\_target\\debug\\tauri-app2.exe\r\r\n"
 Downloading https://go.microsoft.com/fwlink/p/?LinkId=2124703
     Running candle for "main.wxs"
     Running light to produce C:\Users\Fabian-Lars\dev\_target\debug\bundle\msi\tauri-app2_0.1.0_x64_en-US.msi
     Signing C:\Users\Fabian-Lars\dev\_target\debug\bundle\msi\tauri-app2_0.1.0_x64_en-US.msi
     Signing C:\Users\Fabian-Lars\dev\_target\debug\bundle/msi/tauri-app2_0.1.0_x64_en-US.msi with identity "88FB696BE8176B9668F55E027D5AD83027495749"
        Info "Done Adding Additional Store\r\nSuccessfully signed: C:\\Users\\Fabian-Lars\\dev\\_target\\debug\\bundle/msi/tauri-app2_0.1.0_x64_en-US.msi\r\r\n"
        Info Target: x64
     Signing C:\Users\Fabian-Lars\dev\_target\debug\tauri-app2.exe
     Signing C:\Users\Fabian-Lars\dev\_target\debug\tauri-app2.exe with identity "88FB696BE8176B9668F55E027D5AD83027495749"
        Info "Done Adding Additional Store\r\nSuccessfully signed: C:\\Users\\Fabian-Lars\\dev\\_target\\debug\\tauri-app2.exe\r\r\n"
 Downloading https://go.microsoft.com/fwlink/p/?LinkId=2124703
     Running makensis.exe to produce C:\Users\Fabian-Lars\dev\_target\debug\bundle\nsis\tauri-app2_0.1.0_x64-setup.exe
Done Adding Additional Store
Successfully signed: C:\Users\FABIAN~1\AppData\Local\Temp\nst3D2C.tmp
     Signing C:\Users\Fabian-Lars\dev\_target\debug\bundle\nsis\tauri-app2_0.1.0_x64-setup.exe
     Signing C:\Users\Fabian-Lars\dev\_target\debug\bundle/nsis/tauri-app2_0.1.0_x64-setup.exe with identity "88FB696BE8176B9668F55E027D5AD83027495749"
        Info "Done Adding Additional Store\r\nSuccessfully signed: C:\\Users\\Fabian-Lars\\dev\\_target\\debug\\bundle/nsis/tauri-app2_0.1.0_x64-setup.exe\r\r\n"
    Finished 2 bundles at:
        C:\Users\Fabian-Lars\dev\_target\debug\bundle\msi\tauri-app2_0.1.0_x64_en-US.msi
        C:\Users\Fabian-Lars\dev\_target\debug\bundle\nsis\tauri-app2_0.1.0_x64-setup.exe

Gonna try and see if i can confirm that somehow...

[FabianLars]

Well, at least according to the "digital signatures" (translated from german) tab in the file properties of the uninstall.exe it correctly lists the cert like it does on the installer & app. 🥳

[jetli]

I tested this pr too, confirm that the uninstall.exe is signed correctly, thanks! and with the few latest fixes, NSIS works great now!

[amrbashir]

thanks for testing, I marked this as ready for review now