Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove bitness crate from bundler #7405

Merged
merged 5 commits into from
Jul 12, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 11, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

bitness crates is using winapi under the hood while the ecosystem is moving towards using windows-sys crate instead, so this is a step towards removing winapi crate completely from dependencies.

@amrbashir amrbashir requested a review from a team as a code owner July 11, 2023 13:26
wusyong
wusyong previously approved these changes Jul 12, 2023
@lucasfernog lucasfernog merged commit a2be88a into 1.x Jul 12, 2023
@lucasfernog lucasfernog deleted the refactor/bundler/remove-bitness branch July 12, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

3 participants