feat: allow more flexible http requests in updater closes #7422#7432
Merged
lucasfernog merged 4 commits intoAug 10, 2023
Conversation
amrbashir
requested changes
Jul 17, 2023
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
Thank you for the contribution, this looks okay but just needs a few modifications.
Also please add a change file in .changes directory
amrbashir
reviewed
Jul 26, 2023
lucasfernog
approved these changes
Aug 8, 2023
amrbashir
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
These small changes allow us to use AWS SigV4 authenticated requests for checking for updates, and pre-signed S3 URLs for updater downloads - a call flow that was previously not possible.
I'm aware that there is other work in this area in 2.x, but we need to use 1.x for the foreseeable future.