Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): forward onNewIntent event to android plugins #7436

Merged
merged 2 commits into from
Jul 17, 2023
Merged

feat(core): forward onNewIntent event to android plugins #7436

merged 2 commits into from
Jul 17, 2023

Conversation

FabianLars
Copy link
Member

required for the deep link plugin

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@FabianLars FabianLars requested a review from a team as a code owner July 17, 2023 10:58
lucasfernog
lucasfernog reviewed Jul 17, 2023
View reviewed changes
core/tauri/mobile/android-codegen/TauriActivity.kt Outdated

override fun onNewIntent(intent: Intent) {
super.onNewIntent(intent)
if (intent != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intent is never null here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1pm is too early for me apparently 😂

@lucasfernog lucasfernog merged commit a5752db into dev Jul 17, 2023
@lucasfernog lucasfernog deleted the on-new-intent branch July 17, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabianLars @lucasfernog