feat(core): allow a plugin build script to read the plugin config object#7447
Merged
lucasfernog merged 4 commits intodevfrom Jul 18, 2023
Merged
feat(core): allow a plugin build script to read the plugin config object#7447lucasfernog merged 4 commits intodevfrom
lucasfernog merged 4 commits intodevfrom
Conversation
13 tasks
FabianLars
previously approved these changes
Jul 18, 2023
Member
|
One thing that came to mind after approving it, what about dashes in plugin names? At least on windows it seems to work fine but dashes in env var names are a pretty rare occurence so idk if it can cause any issues? |
Member
Author
|
Pushed a change just in case @FabianLars but it should work fine, at least on unix that's ok too. |
FabianLars
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information