Skip to content

feat(core): allow a plugin build script to read the plugin config object#7447

Merged
lucasfernog merged 4 commits intodevfrom
feat/plugin-config-env-var
Jul 18, 2023
Merged

feat(core): allow a plugin build script to read the plugin config object#7447
lucasfernog merged 4 commits intodevfrom
feat/plugin-config-env-var

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner July 18, 2023 12:28
FabianLars
FabianLars previously approved these changes Jul 18, 2023
@FabianLars
Copy link
Member

One thing that came to mind after approving it, what about dashes in plugin names? At least on windows it seems to work fine but dashes in env var names are a pretty rare occurence so idk if it can cause any issues?

@lucasfernog
Copy link
Member Author

Pushed a change just in case @FabianLars but it should work fine, at least on unix that's ok too.

@lucasfernog lucasfernog merged commit 522de0e into dev Jul 18, 2023
@lucasfernog lucasfernog deleted the feat/plugin-config-env-var branch July 18, 2023 14:04
krzykro2 pushed a commit to krzykro2/tauri that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants