fix(driver): bump locked dependencies to fix build issue on Windows - #7475
Merged
Conversation
Member
|
@AlexTMjugador we should target the 1.x branch for this change. The dev branch is now tracking the v2 release. |
Contributor
Author
|
Thanks for the heads-up, I'll rebase the PR! |
Contributor
Author
|
While comparing base branches, I noticed that it might be a good idea to cherry-pick #7260 too, given that it also fixes some build issues. |
lucasfernog
approved these changes
Aug 8, 2023
Member
|
Thanks for catching it @AlexTMjugador ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Currently, it is not possible to build the latest release of
tauri-driverincrates.iofor Windows when dependency versions are resolved as specified in the dependency lock file. This is caused due to undefined behavior onntapi< 0.4.0, which is now rejected by recent Rust compilers [1] [2]:This circumstance is not an issue for bare
cargo installcommands, but it creates problems when passing the--lockedflag, which the populartaiki-e/install-actiondoes unconditionally, and may be desired by some security-conscious users. In addition, it degrades the Windows development experience fortauri-driver, as new contributors have to runcargo updateto be able to build the project.If these changes are merged, I'd recommend publishing a new
tauri-driverpatch version so that the latestcrates.iorelease doesn't ship with an outdatedCargo.lock.While at it, I've upgraded the MSRV to match the Tauri project and be more compatible with transitive dependencies.