Skip to content

fix(bundler): do not skip updater bundle target if only a macOS DMG is generated#7481

Merged
lucasfernog merged 1 commit intotauri-apps:1.xfrom
ComunidadAylas:fix/macos-dmg-updater
Jul 24, 2023
Merged

fix(bundler): do not skip updater bundle target if only a macOS DMG is generated#7481
lucasfernog merged 1 commit intotauri-apps:1.xfrom
ComunidadAylas:fix/macos-dmg-updater

Conversation

@AlexTMjugador
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

As explained in #7189 (comment), this little change addresses recent, unintended behavior changes in how the updater bundle operates.

@AlexTMjugador AlexTMjugador requested a review from a team as a code owner July 22, 2023 16:50
@amrbashir
Copy link
Member

I think we only support updating .app on macOS, and so DMG should be ignored if it is the only macOS target specified. cc @lucasfernog

@AlexTMjugador
Copy link
Contributor Author

As far as I know, DMGs are containers for .app bundles, so generating a DMG implies generating an .app bundle and it is technically possible to update an application that was installed from a DMG by replacing its .app. But I stumbled upon this on CI when updating Tauri, and I don't have a Mac to confirm, so please take this with a grain of salt!

@lucasfernog
Copy link
Member

@AlexTMjugador you're right. Thanks for catching this and contributing!

@lucasfernog lucasfernog merged commit 2d35f93 into tauri-apps:1.x Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

3 participants