Skip to content

fix(bundler/nsis): use temp dir for webview2 installer, closes #7409#7486

Merged
amrbashir merged 2 commits intotauri-apps:1.xfrom
jetli:fix_nsis
Jul 25, 2023
Merged

fix(bundler/nsis): use temp dir for webview2 installer, closes #7409#7486
amrbashir merged 2 commits intotauri-apps:1.xfrom
jetli:fix_nsis

Conversation

@jetli
Copy link
Contributor

@jetli jetli commented Jul 24, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@jetli jetli requested a review from a team as a code owner July 24, 2023 11:40
@lucasfernog lucasfernog requested a review from amrbashir July 24, 2023 12:31
@amrbashir
Copy link
Member

Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example.

@jetli
Copy link
Contributor Author

jetli commented Jul 25, 2023

Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example.

@amrbashir signed the commit

@jetli
Copy link
Contributor Author

jetli commented Jul 25, 2023

and should I send another pr for 2.0 dev branch?

@FabianLars
Copy link
Member

FabianLars commented Jul 25, 2023

Nope. We will merge the 1.x branch into dev one last time when 1.5 is released.

@amrbashir amrbashir merged commit 57f73f1 into tauri-apps:1.x Jul 25, 2023
@jetli jetli deleted the fix_nsis branch July 26, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

3 participants