fix(bundler/nsis): use temp dir for webview2 installer, closes #7409#7486
Merged
amrbashir merged 2 commits intotauri-apps:1.xfrom Jul 25, 2023
jetli:fix_nsis
Merged
fix(bundler/nsis): use temp dir for webview2 installer, closes #7409#7486amrbashir merged 2 commits intotauri-apps:1.xfrom jetli:fix_nsis
amrbashir merged 2 commits intotauri-apps:1.xfrom
jetli:fix_nsis
Conversation
amrbashir
reviewed
Jul 24, 2023
Member
|
Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example. |
Contributor
Author
@amrbashir signed the commit |
Contributor
Author
|
and should I send another pr for 2.0 dev branch? |
Member
|
Nope. We will merge the 1.x branch into dev one last time when 1.5 is released. |
amrbashir
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information