Skip to content

fix(bundler/nsis): revert shell context change before deleting appdata, closes #7588#7591

Merged
amrbashir merged 3 commits intotauri-apps:1.xfrom
jetli:fix_uninstall_delete_app_data
Aug 15, 2023
Merged

fix(bundler/nsis): revert shell context change before deleting appdata, closes #7588#7591
amrbashir merged 3 commits intotauri-apps:1.xfrom
jetli:fix_uninstall_delete_app_data

Conversation

@jetli
Copy link
Contributor

@jetli jetli commented Aug 11, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@jetli jetli requested a review from a team as a code owner August 11, 2023 09:04
@FabianLars FabianLars requested a review from amrbashir August 14, 2023 09:22
@amrbashir amrbashir changed the title fix(bundler/nsis): delete app data of current user when uninstall, closes #7588 fix(bundler/nsis): revert shell context change before deleting appdata, closes #7588 Aug 15, 2023
@amrbashir amrbashir merged commit ca977f4 into tauri-apps:1.x Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants