refactor(bundler): switch to notarytool, closes #4300#7616
Merged
Conversation
amrbashir
reviewed
Aug 14, 2023
Member
amrbashir
left a comment
There was a problem hiding this comment.
releasing this as a minor release might break some users CI, should it be added behind a flag and the default would warn users that it is to be discontinued soon and they should migrate?
Member
Author
|
It will break anyway in a couple months... |
Member
|
true but we could have a soft migration at the moment instead of breaking their CI early on. |
Member
|
tbh i feel like it's too late for that now, especially with our slow-ish release cycle |
Member
Author
|
We could also look for the API key file on the known paths Apple used to look for it... |
amrbashir
approved these changes
Aug 15, 2023
lucasfernog
added a commit
that referenced
this pull request
Sep 7, 2023
lucasfernog
added a commit
that referenced
this pull request
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information