Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bundler): switch to notarytool, closes #4300 #7616

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner August 14, 2023 18:39
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

releasing this as a minor release might break some users CI, should it be added behind a flag and the default would warn users that it is to be discontinued soon and they should migrate?

@lucasfernog
Copy link
Member Author

It will break anyway in a couple months...

@amrbashir
Copy link
Member

true but we could have a soft migration at the moment instead of breaking their CI early on.

@FabianLars
Copy link
Member

tbh i feel like it's too late for that now, especially with our slow-ish release cycle

@lucasfernog
Copy link
Member Author

We could also look for the API key file on the known paths Apple used to look for it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

4 participants