Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: take id for text/check/icon on menu builders #7621

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner August 15, 2023 14:32
@wusyong
Copy link
Member

wusyong commented Aug 16, 2023

Can id be Option? Or could we add additional methods like text_with_id, icon_with_id?

@amrbashir
Copy link
Member Author

Without providing an id, the create menu item is just useless because you didn't set its id and have no way to get the id afterwards, except iterating through the children of the generated menu and comparing it to the text you provided but sounds unnecessary and would be bad DX to use when reacting to menu events.

@lucasfernog lucasfernog merged commit 5c95152 into dev Aug 16, 2023
1 check passed
@lucasfernog lucasfernog deleted the refactor/menu-builders-id branch August 16, 2023 14:55
yydcnjjw pushed a commit to yydcnjjw/tauri that referenced this pull request Sep 8, 2023
)

Co-authored-by: Lucas Nogueira <lucas@tauri.studio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

3 participants