Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add append option to writeFile apis #7636

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Conversation

FabianLars
Copy link
Member

#7092

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@FabianLars FabianLars requested a review from a team as a code owner August 16, 2023 13:13
tooling/api/src/fs.ts Outdated Show resolved Hide resolved
*
* @since 1.5.0
*/
append?: boolean
// note that adding fields here needs a change in the writeBinaryFile check
Copy link
Member Author

@FabianLars FabianLars Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't understand what this means

@FabianLars
Copy link
Member Author

even tokio is betraying us now, holy shit 😂

amrbashir
amrbashir previously approved these changes Aug 16, 2023
@amrbashir
Copy link
Member

and clippy failed too

FabianLars and others added 2 commits August 16, 2023 15:56
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@amrbashir amrbashir merged commit 58d6b89 into 1.x Aug 16, 2023
@amrbashir amrbashir changed the title feat(api): Add append option to writeFile apis. feat(api): Add append option to writeFile apis Aug 16, 2023
@amrbashir amrbashir deleted the fs-append-file branch August 16, 2023 16:09
@amrbashir
Copy link
Member

Lets fix the tokio issue in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

2 participants