Skip to content

fix: rpath missing from app, closes #7710 - #7773

Merged
lucasfernog merged 11 commits into
tauri-apps:1.xfrom
tr3ysmith:rpath
Sep 24, 2023
Merged

fix: rpath missing from app, closes #7710#7773
lucasfernog merged 11 commits into
tauri-apps:1.xfrom
tr3ysmith:rpath

Conversation

@tr3ysmith

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • [ X] No

Other information

#7710

@Brendonovich

Copy link
Copy Markdown
Member

Seems like this also closes #7480. Symlinks in the Frameworks folder weren't being preserved but using this PR they are.

@Beanow Beanow added type: bug scope: core Core packages of Tauri status: needs review A maintainer must review this code platform: macOS security: needs feedback This issue/PR needs feeback from wg-security labels Sep 15, 2023
Comment thread core/tauri-build/src/lib.rs Outdated
@lucasfernog

Copy link
Copy Markdown
Member

Can you rebase your branch to sign the ef8a58d commit?

@tr3ysmith

Copy link
Copy Markdown
Contributor Author

Can you rebase your branch to sign the ef8a58d commit?

Should be good now

@tweidinger

Copy link
Copy Markdown
Contributor

Only concerns from sec perspective would be if @executable_path/../Frameworks is (world/all users) writeable, which from my understanding is not the case for apps properly deployed in macos (development seems a little different) and the application loading the relative libraries is not a suid binary, which is very rarely the case for a tauri application.

I think this would need to be documented for MacOS apps as risks for privilege escalation in case some privileged calls/libs/permissions are used/called from the Tauri app otherwise LGTM

@tweidinger tweidinger added security: feedback loop wg-security added some feedback but no conclusion based on feedback and removed security: needs feedback This issue/PR needs feeback from wg-security labels Sep 20, 2023
@lucasfernog

Copy link
Copy Markdown
Member

@tr3ysmith can you double check my latest commit and see if af13f20 (#7773) works fine on your setup?

@tr3ysmith

Copy link
Copy Markdown
Contributor Author

@tr3ysmith can you double check my latest commit and see if af13f20 (#7773) works fine on your setup?

Yeah that seems to work great, I was able to remove my build script and it worked.

@lucasfernog
lucasfernog merged commit 5ecb46b into tauri-apps:1.x Sep 24, 2023
@tr3ysmith
tr3ysmith deleted the rpath branch September 24, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: macOS scope: core Core packages of Tauri security: feedback loop wg-security added some feedback but no conclusion based on feedback status: needs review A maintainer must review this code type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants