feat: add team_id option for apple notarization #7775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
tr3ysmith
changed the title
afonsojramos
approved these changes
Sep 15, 2023
lucasfernog
approved these changes
Sep 15, 2023
jason-crabnebula
added a commit
to jason-crabnebula/cargo-packager
that referenced
this pull request
Oct 18, 2023
Port of tauri-apps/tauri#7775 Co-authored-by: Trey Smith <trey@fulcrum-acoustic.com> Co-authored-by: Lucas Nogueira <lucas@tauri.app>
jason-crabnebula
added a commit
to jason-crabnebula/cargo-packager
that referenced
this pull request
Oct 18, 2023
Port of tauri-apps/tauri#7775 Co-authored-by: Trey Smith <trey@fulcrum-acoustic.com> Co-authored-by: Lucas Nogueira <lucas@tauri.app>
lucasfernog-crabnebula
added a commit
to crabnebula-dev/cargo-packager
that referenced
this pull request
Oct 23, 2023
* feat(macos): add team_id option for apple notarization Port of tauri-apps/tauri#7775 Co-authored-by: Trey Smith <trey@fulcrum-acoustic.com> Co-authored-by: Lucas Nogueira <lucas@tauri.app> * fix(macos): fix notraytool's apple-id option name Port of tauri-apps/tauri#7934 Co-authored-by: Jason Tsai <jason@pews.dev> Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app> * fix(macos): team ID is now required for notarytool via app password Port of tauri-apps/tauri#7972 Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app> * refactor: remove Error::MissingNotarizeAuthTeamId Co-authored-by: Lucas Nogueira <lucas@crabnebula.dev> --------- Co-authored-by: Trey Smith <trey@fulcrum-acoustic.com> Co-authored-by: Lucas Nogueira <lucas@tauri.app> Co-authored-by: Jason Tsai <jason@pews.dev> Co-authored-by: Lucas Nogueira <lucas@crabnebula.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds an optional APPLE_TEAM_ID variable to notarization on MacOS when using Apple ID and Password authentication. This is useful if people belong to multiple teams.
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information