feat: Add files field in macos build config, closes #3290#7798
Merged
lucasfernog merged 9 commits intotauri-apps:devfrom Dec 28, 2023
Merged
feat: Add files field in macos build config, closes #3290#7798lucasfernog merged 9 commits intotauri-apps:devfrom
lucasfernog merged 9 commits intotauri-apps:devfrom
Conversation
simonhyll
approved these changes
Sep 11, 2023
Contributor
simonhyll
left a comment
simonhyll
left a comment
There was a problem hiding this comment.
Untested but code wise looks good to me
repalash
force-pushed
the
mac-app-contents
branch
from
721416e to
522616c
Compare
…to DebConfig::files.
repalash
force-pushed
the
mac-app-contents
branch
from
522616c to
29bc5dd
Compare
repalash
changed the title
Contributor
Author
|
Edited to make it similar to DebConfig::files. |
pewsheen
reviewed
Sep 12, 2023
examples/helloworld/tauri.conf.json
Outdated
| }, | ||
| "macOS": { | ||
| "frameworks": [], | ||
| "appContents": [], |
Contributor
Author
|
Nothing left from my side, @pewsheen is it all good? |
Contributor
The code looks to me. But I remembered there are some discussions about signing files in the |
|
I tested this code out and have a couple of comments
|
lucasfernog
approved these changes
Dec 28, 2023
Member
lucasfernog
left a comment
lucasfernog
left a comment
There was a problem hiding this comment.
LGTM, nice work! I think codesign should be handled separately, probably on #8259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Added a new field,
appContentsto tauri macos bundle config. Any files and directories added here are copied to the app bundle under theContentsdirectory.This makes it possible to add custom
Libraryitems,Pluginsbuilt separately with code etc as requested in #3290Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
It's my first PR here. Let me know if you want to change the field name or copy logic, or if these kinds of PRs are not accepted.