fix: remove mut self from set_native_icon signature#7866
Merged
amrbashir merged 5 commits intotauri-apps:devfrom Sep 20, 2023
Merged
fix: remove mut self from set_native_icon signature#7866amrbashir merged 5 commits intotauri-apps:devfrom
amrbashir merged 5 commits intotauri-apps:devfrom
Conversation
amrbashir
requested changes
Sep 20, 2023
Member
amrbashir
left a comment
There was a problem hiding this comment.
Thank you for your contributions! Could you also add a changefile in .changes directory?
logankeenan
commented
Sep 20, 2023
Contributor
Author
|
@amrbashir, thanks for the feedback. All changes have been made |
amrbashir
reviewed
Sep 20, 2023
amrbashir
approved these changes
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
I'm getting a compile error in the latest alpha release. The error can be reproduced with this repo by running
cargo tauri dev. It looks like the bug was introduced here.Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information