Skip to content

refactor!: remove unnecessary error enum and result type aliases#7875

Merged
lucasfernog merged 4 commits intodevfrom
refactor/remove-unneeded-result-aliases
Oct 17, 2023
Merged

refactor!: remove unnecessary error enum and result type aliases#7875
lucasfernog merged 4 commits intodevfrom
refactor/remove-unneeded-result-aliases

Conversation

@amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 21, 2023

ref: #7756

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 21, 2023 04:38
@lucasfernog
Copy link
Member

We can't remove the plugin Result type because it needs to take a dyn std::error::Error to let plugin authors use their own error types.

@amrbashir
Copy link
Member Author

yeah it is fine to keep then.

@lucasfernog lucasfernog merged commit 12b8d18 into dev Oct 17, 2023
@lucasfernog lucasfernog deleted the refactor/remove-unneeded-result-aliases branch October 17, 2023 16:10
@amrbashir
Copy link
Member Author

@lucasfernog would it make more sense to inline the type instead? just trying to avoid multiple result aliases when a user searches on docs.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants