refactor(core&api)!: hide internal functions and reuse them in api.js & rename tauri module to primitives#7942
Merged
lucasfernog merged 18 commits intodevfrom Oct 17, 2023
Merged
Conversation
14 tasks
tauri module to primitives
tauri module to primitivestauri module to primitives
Member
|
There's a reason we're not adding everything on TAURI: we replace that whole object if withGlobalTauri is set to true: tauri/tooling/api/tsup.config.ts Line 31 in c0d03af I pushed some changes on your script, but that part of this PR can't be touched (unless we rename TAURI to something else for core scripts). |
Member
Author
|
I guess we need to change the place we store these internals, or change |
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @sveltejs/vite-plugin-svelte@1.0.1 |
Member
Author
|
Moved to |
tauri module to primitivestauri module to primitives
lucasfernog
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #7756
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
This PR aims to hide all internal functions and properties from the global
windowobject and towindow.__TAURI__.__INTERNALS__and also changes@tauri-apps/apito use these functions instead of redefining the logic again.Also renamed
taurimodule toprimitivesand removed the undocumentedinvokere-export in the root module.