Skip to content

feat(api): add mock for convertFileSrc, closes #7935#7961

Merged
amrbashir merged 5 commits into1.xfrom
feat/api/convertFileSrc-mock
Oct 17, 2023
Merged

feat(api): add mock for convertFileSrc, closes #7935#7961
amrbashir merged 5 commits into1.xfrom
feat/api/convertFileSrc-mock

Conversation

@amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner October 5, 2023 00:47
@amrbashir amrbashir merged commit 2b0212a into 1.x Oct 17, 2023
@amrbashir amrbashir deleted the feat/api/convertFileSrc-mock branch October 17, 2023 12:33
@@ -0,0 +1,5 @@
---
'@tauri-apps/api': 'minor:feat'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amrbashir can we change this to a patch so we can release the Debian package hotfix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've got to have selective release in our workflow, this is not scalable IMO, but I will revert this bump.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we should have that :( it's always so boring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

3 participants