Skip to content

fix(bundler): team ID is now required for notarytool via app password#7972

Merged
lucasfernog merged 3 commits into1.xfrom
fix/team-id-required
Oct 6, 2023
Merged

fix(bundler): team ID is now required for notarytool via app password#7972
lucasfernog merged 3 commits into1.xfrom
fix/team-id-required

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner October 6, 2023 15:50
FabianLars
FabianLars previously approved these changes Oct 6, 2023
@FabianLars
Copy link
Member

(should have waited with the approval. i forgot that it gets dismissed on each commit. see you after you fixed ci 😂)

@lucasfernog lucasfernog merged commit 40d3400 into 1.x Oct 6, 2023
@lucasfernog lucasfernog deleted the fix/team-id-required branch October 6, 2023 17:33
lucasfernog added a commit that referenced this pull request Oct 8, 2023
lucasfernog added a commit that referenced this pull request Oct 8, 2023
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
fix(bundler): team ID is now required for notarytool via app password (#7972)
fix(bundler): team ID is now required for notarytool via app password (#7972)"
jason-crabnebula added a commit to jason-crabnebula/cargo-packager that referenced this pull request Oct 18, 2023
Port of tauri-apps/tauri#7972

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
jason-crabnebula added a commit to jason-crabnebula/cargo-packager that referenced this pull request Oct 18, 2023
Port of tauri-apps/tauri#7972

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
lucasfernog-crabnebula added a commit to crabnebula-dev/cargo-packager that referenced this pull request Oct 23, 2023
* feat(macos): add team_id option for apple notarization
Port of tauri-apps/tauri#7775

Co-authored-by: Trey Smith <trey@fulcrum-acoustic.com>
Co-authored-by: Lucas Nogueira <lucas@tauri.app>

* fix(macos): fix notraytool's apple-id option name
Port of tauri-apps/tauri#7934

Co-authored-by: Jason Tsai <jason@pews.dev>
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>

* fix(macos): team ID is now required for notarytool via app password
Port of tauri-apps/tauri#7972

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>

* refactor: remove Error::MissingNotarizeAuthTeamId

Co-authored-by: Lucas Nogueira <lucas@crabnebula.dev>

---------

Co-authored-by: Trey Smith <trey@fulcrum-acoustic.com>
Co-authored-by: Lucas Nogueira <lucas@tauri.app>
Co-authored-by: Jason Tsai <jason@pews.dev>
Co-authored-by: Lucas Nogueira <lucas@crabnebula.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

2 participants