fix(bundler): In .deb packages, set uid=0 for all files#7980
Merged
lucasfernog merged 1 commit intotauri-apps:1.xfrom Oct 16, 2023
Merged
fix(bundler): In .deb packages, set uid=0 for all files#7980lucasfernog merged 1 commit intotauri-apps:1.xfrom
lucasfernog merged 1 commit intotauri-apps:1.xfrom
Conversation
92249a7 to
d1fa43f
Compare
Member
|
Thanks for the PR! Since we didn't merge 1.x back into dev yet (should happen once the 1.5 release calmed down a bit) i think this should target the 1.x branch instead so 1.x users get the fix faster. |
In Debian packages, set `root` the owner of control files and package files (uid=0, gid=0).
d1fa43f to
f2e9b62
Compare
Contributor
Author
|
Thanks @FabianLars, I've rebased the PR to target branch |
tweidinger
approved these changes
Oct 16, 2023
Contributor
|
Thanks for this security relevant improvement 👍 |
lucasfernog
approved these changes
Oct 16, 2023
amr-crabnebula
added a commit
to crabnebula-dev/cargo-packager
that referenced
this pull request
Oct 18, 2023
Port of tauri-apps/tauri#7980 Co-authored-by: Olivier Lemasle <o.lemasle@gmail.com>
amr-crabnebula
added a commit
to crabnebula-dev/cargo-packager
that referenced
this pull request
Oct 18, 2023
Port of tauri-apps/tauri#7980 Co-authored-by: Olivier Lemasle <o.lemasle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
This solves one of the issues reported in #7074:
lintian(the Debian package linter) reported these errors:The Debian package file contains two archive files (
control.tar.gzanddata.tar.gz) which are created with file metadata copied from the build filesystem: mode, time, uid, gid, etc.That caused the package to use the uid of the build user (typically an unprivileged user with
uid1000) instead of therootuser as required.With this commit, the metadata are still copied, except for
uidandgid, which are overridden and set to0(=root).