Skip to content

fix(bundler): WebView2 offline installer GUID changes#7998

Merged
lucasfernog merged 2 commits intotauri-apps:1.xfrom
i-c-b:1.x
Oct 11, 2023
Merged

fix(bundler): WebView2 offline installer GUID changes#7998
lucasfernog merged 2 commits intotauri-apps:1.xfrom
i-c-b:1.x

Conversation

@i-c-b
Copy link
Contributor

@i-c-b i-c-b commented Oct 11, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@i-c-b i-c-b requested a review from a team as a code owner October 11, 2023 05:26
nothingismagick
nothingismagick approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@nothingismagick nothingismagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasfernog lucasfernog merged commit f552c17 into tauri-apps:1.x Oct 11, 2023
@i-c-b i-c-b deleted the 1.x branch October 23, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

@nothingismagick nothingismagick nothingismagick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Roadmap
Status: 🔎 In audit

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@i-c-b @lucasfernog @nothingismagick