Skip to content

fix(bundler): read proxy when downloading resources.#8012

Merged
amrbashir merged 4 commits intotauri-apps:1.xfrom
CaiJingLong:1.x
Oct 13, 2023
Merged

fix(bundler): read proxy when downloading resources.#8012
amrbashir merged 4 commits intotauri-apps:1.xfrom
CaiJingLong:1.x

Conversation

@CaiJingLong
Copy link
Contributor

@CaiJingLong CaiJingLong commented Oct 13, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

closes #7985

@CaiJingLong
fix(bundler): read http_proxy env when downloading resources.
89c5175 
Signed-off-by: CaiJingLong <cjl_spy@163.com>
@CaiJingLong CaiJingLong requested a review from a team as a code owner October 13, 2023 05:38
@CaiJingLong CaiJingLong mentioned this pull request Oct 13, 2023
Closed
13 tasks
amrbashir
amrbashir reviewed Oct 13, 2023
View reviewed changes
amrbashir
amrbashir reviewed Oct 13, 2023
View reviewed changes
amrbashir
amrbashir approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir amrbashir merged commit d0ae675 into tauri-apps:1.x Oct 13, 2023
amrbashir added a commit that referenced this pull request Oct 13, 2023
@amrbashir
chore: update tauri-cli lock file
a067fa4 
#8012 is using `AgentBuilder::try_proxy_from_env` which is introduced in ureq@2.8
@amrbashir amrbashir mentioned this pull request Oct 13, 2023
Merged
13 tasks
amr-crabnebula added a commit to crabnebula-dev/cargo-packager that referenced this pull request Oct 18, 2023
@amr-crabnebula @CaiJingLong
fix: read proxy when downloading resources
6c6b8db 
Port of tauri-apps/tauri#8012

Co-authored-by: Caijinglong <cjl_spy@163.com>
@amr-crabnebula amr-crabnebula mentioned this pull request Oct 18, 2023
Merged
amr-crabnebula added a commit to crabnebula-dev/cargo-packager that referenced this pull request Oct 18, 2023
@amr-crabnebula @CaiJingLong
fix: read proxy when downloading resources (#49)
274a6be 
Port of tauri-apps/tauri#8012

Co-authored-by: Caijinglong <cjl_spy@163.com>
@FabianLars FabianLars mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Roadmap
Status: 🔎 In audit

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaiJingLong @amrbashir