Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler): read proxy when downloading resources. #8012

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

CaiJingLong
Copy link
Contributor

@CaiJingLong CaiJingLong commented Oct 13, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

closes #7985

Signed-off-by: CaiJingLong <cjl_spy@163.com>
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir amrbashir merged commit d0ae675 into tauri-apps:1.x Oct 13, 2023
9 checks passed
amrbashir added a commit that referenced this pull request Oct 13, 2023
#8012 is using `AgentBuilder::try_proxy_from_env` which is introduced in ureq@2.8
@amrbashir amrbashir mentioned this pull request Oct 13, 2023
13 tasks
amr-crabnebula added a commit to crabnebula-dev/cargo-packager that referenced this pull request Oct 18, 2023
Port of tauri-apps/tauri#8012

Co-authored-by: Caijinglong <cjl_spy@163.com>
amr-crabnebula added a commit to crabnebula-dev/cargo-packager that referenced this pull request Oct 18, 2023
Port of tauri-apps/tauri#8012

Co-authored-by: Caijinglong <cjl_spy@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

2 participants