Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump MSRV to 1.70 #8031

Merged
merged 7 commits into from
Oct 17, 2023
Merged

chore: bump MSRV to 1.70 #8031

merged 7 commits into from
Oct 17, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner October 17, 2023 11:29
@lucasfernog lucasfernog changed the title chore: bump MSRV to 1.74 chore: bump MSRV to 1.73 Oct 17, 2023
@amrbashir
Copy link
Member

Isn't 1.73 a bit too high?

@lucasfernog
Copy link
Member Author

Well until we release stable it'll be ok 😂 but we can do 1.70 for now (did we decide on the MSRV policy?)

@amrbashir
Copy link
Member

I think the consensus at the moment is 3 versions so 1.70 is fine.

@lucasfernog lucasfernog changed the title chore: bump MSRV to 1.73 chore: bump MSRV to 1.70 Oct 17, 2023
@lucasfernog lucasfernog merged commit 880266a into dev Oct 17, 2023
2 checks passed
@lucasfernog lucasfernog deleted the chore/bump-msrv branch October 17, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

2 participants