Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Downgrade minisign to 0.7.3 again #8082

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

FabianLars
Copy link
Member

rust-minisign was upgraded to 0.7.5 in the last patch release via #7641 even though it was pinned. It was downgraded because 0.7.5 breaks the update bundle signer if an empty password is provided, see FabianLars/mw-toolbox#550 (pr that made me notice the change) and jedisct1/rust-minisign#26 (upstream issue i opened) and #7197 (the last time i downgraded it)

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@FabianLars FabianLars requested a review from a team as a code owner October 23, 2023 09:28
@FabianLars FabianLars changed the base branch from dev to 1.x October 23, 2023 09:28
@antkit
Copy link

antkit commented Oct 23, 2023

Waiting for merging, as i upgrade tauri from 1.4 to 1.5 yesterday and now i can't build my project with empty password...

@lucasfernog lucasfernog merged commit 5264e41 into 1.x Oct 23, 2023
12 checks passed
@lucasfernog lucasfernog deleted the downgrade-minisign branch October 23, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants