Skip to content

fix(core): docs.rs build failing for macOS#8095

Merged
lucasfernog merged 1 commit into1.xfrom
fix/docs.rs-macos-build
Nov 14, 2023
Merged

fix(core): docs.rs build failing for macOS#8095
lucasfernog merged 1 commit into1.xfrom
fix/docs.rs-macos-build

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner October 24, 2023 22:15
@lucasfernog lucasfernog changed the title fix(deps): Downgrade minisign to 0.7.3 again (#8082) @lucasfernog fix(core): docs.rs build failing for macOS Oct 24, 2023
@lucasfernog lucasfernog changed the title @lucasfernog fix(core): docs.rs build failing for macOS fix(core): docs.rs build failing for macOS Oct 24, 2023
@lucasfernog
Copy link
Member Author

basically we can't compile mac-notification-sys on docs.rs :/

@lucasfernog lucasfernog merged commit 2ba8856 into 1.x Nov 14, 2023
@lucasfernog lucasfernog deleted the fix/docs.rs-macos-build branch November 14, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants