fix(cli): Fixes errors on command output, closes #8110#8162
Merged
lucasfernog merged 1 commit intotauri-apps:1.xfrom Nov 9, 2023
Merged
fix(cli): Fixes errors on command output, closes #8110#8162lucasfernog merged 1 commit intotauri-apps:1.xfrom
lucasfernog merged 1 commit intotauri-apps:1.xfrom
Conversation
87f6453 to
e57042a
Compare
lucasfernog
requested changes
Nov 6, 2023
The error occurs when the command output stream contains an invalid UTF-8 character, or ends with a multi-bytes UTF-8 character. Fixes tauri-apps#8110
e57042a to
a171b89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command output was fixed in #8042; however it also created two issues:
tauri/tooling/bundler/src/bundle/common.rs
Lines 183 to 194 in ae75004
read_linereturnsErr(which happens if the stream contains an invalid UTF-8 character),lineis empty and&line[0..line.len() - 1]fails (attempt to subtract with overflow)That happens on macos with
bundle_dmg.shwhen the product name contains a Chinese character or an emoji (cf "--verbose" parameter cause "cargo tauri build" error #8110).linedoes not end with\n. Therefore, the last byte of the stream is removed. If this is e.g. an ASCII character, it's just one character missing in the output. If the last character is multi-bytes, it throws an error (byte index xxx is not a char boundary; it is inside xxx)What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
Fixes #8110