Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): avoid crashing in clearMocks, closes #8179 #8219

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

MGough
Copy link
Contributor

@MGough MGough commented Nov 13, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Prevents tests that didn't define any mocks from failing in afterEach test hook.

Just backports this PR into 1.x as the bug is also present there

…ned (fix: tauri-apps#8179)

Prevents tests that didn't define any mocks from failing in `afterEach` test hook.
amrbashir
amrbashir previously approved these changes Nov 13, 2023
@amrbashir amrbashir changed the title fix(api): do nothing in clearMocks if __TAURI_INTERNALS__ is not defined (fix: #8179) fix(api): avoid crashing in clearMocks, closes #8179 Nov 13, 2023
@amrbashir amrbashir merged commit 14544e4 into tauri-apps:1.x Nov 13, 2023
10 checks passed
@MGough MGough deleted the fix-clearmocks branch November 13, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants