Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add test::test::get_ipc_response, closes #8199 #8228

Merged
merged 8 commits into from
Dec 14, 2023

Conversation

vdang-crabnebula
Copy link
Contributor

@vdang-crabnebula vdang-crabnebula commented Nov 15, 2023

#8199
Some helper functions added to the tauri::test::MockRuntime that can help to fuzz Tauri applications.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@vdang-crabnebula vdang-crabnebula marked this pull request as ready for review November 15, 2023 09:10
@vdang-crabnebula vdang-crabnebula requested a review from a team as a code owner November 15, 2023 09:10
@lucasfernog
Copy link
Member

We have assert_ipc_response which works in a similar way, maybe we can add a variant to only return the response instead of asserting it. Does it really need to be coupled with app.run and app.run_iteration? Can't that be done on your end?

@vdang-crabnebula
Copy link
Contributor Author

We have assert_ipc_response which works in a similar way, maybe we can add a variant to only return the response instead of asserting it. Does it really need to be coupled with app.run and app.run_iteration? Can't that be done on your end?

Well you're right, it shouldn't be in the Tauri code. I will do another proposal and move most code into my fuzzing lib

Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.app>
@lucasfernog lucasfernog changed the title feat(core): add helper functions to the MockRuntime, closes #8199 feat(core): add test::test::get_ipc_response, closes #8199 Dec 14, 2023
@lucasfernog lucasfernog merged commit 3c371aa into tauri-apps:1.x Dec 14, 2023
10 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants