fix(bundler/nsis): remove empty resources folders on uninstall #8263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a tiny bit offtopic but does somebody know how to get rid of this one?
I can't run clippy locally because of it and have to wait for CI to tell me where i did something dumb. |
|
Also because of the reverse order this looks like an awful suggestion |
amrbashir
approved these changes
Nov 20, 2023
amr-crabnebula
added a commit
to crabnebula-dev/cargo-packager
that referenced
this pull request
Nov 30, 2023
tauri-apps/tauri#8263 Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
amr-crabnebula
added a commit
to crabnebula-dev/cargo-packager
that referenced
this pull request
Nov 30, 2023
tauri-apps/tauri#8263 Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #8233, so please read that PR description for context.
Currently the uninstaller only deletes the top-level resources folders. NSIS' rmdir function has a
/Rflag for recursive deletion but i thought that it has to follow the "Delete application data" checkbox, even if the installdir is not the data dirs we expose with the bundle id. This makes it quite a bit morecomplicatedspammy since now we have to delete each folder level seperately...If we prefer to use the /R over a much bigger uninstaller then i'll be happy to adapt this PR, this is just how i understood it was meant to work :)
p.s. The uninstaller now recursively deletes the installdir too if the checkbox is ticked, just in case the dev added files in there too.