Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): add top-level main, module and types fields #8267

merged 8 commits into from
Nov 20, 2023


Copy link

@amrbashir amrbashir commented Nov 20, 2023

Also simplify js output, backported from dev #8025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No


  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner November 20, 2023 13:57
@amrbashir amrbashir changed the title fix(api): add top-level main, module and types fields Also simplify js output, backported from dev fix(api): add top-level main, module and types fields Nov 20, 2023
Copy link

socket-security bot commented Nov 20, 2023

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/node 20.9.0 None +0 3.92 MB types
@rollup/plugin-terser 0.4.4 eval +2 117 kB lukastaegert
@rollup/plugin-typescript 11.1.5 None +2 158 kB lukastaegert

🚮 Removed packages: tsup@6.7.0

@lucasfernog lucasfernog merged commit 5046270 into 1.x Nov 20, 2023
11 checks passed
@lucasfernog lucasfernog deleted the fix/moduleResolution-node branch November 20, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants