Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): expose CLI signer flags as environment variables #8327

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

Hacksore
Copy link
Contributor

@Hacksore Hacksore commented Dec 2, 2023

Expose TAURI_PRIVATE_KEY_PASSWORD, TAURI_PRIVATE_KEY_PASSWORD, and TAURI_PRIVATE_KEY to make it easier to use the CLI in a CI environment.

In theory we can then call this with all the vars set to create a signature.

tauri signer sign *.exe

Although I saw that this renames the vars https://github.com/tauri-apps/tauri/blob/dev/.changes/cli-env-vars.md

I'm assuming that's a v2 breaking change and I'm not sure if I should adopt those values for this PR.

Guidance from the core team is extremely appreciated. thanks!

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@Hacksore Hacksore requested a review from a team as a code owner December 2, 2023 14:58
@Hacksore Hacksore force-pushed the feat/allow-sign-env-vars branch from e957c6c to 70701f4 Compare December 2, 2023 14:59
@amrbashir
Copy link
Member

Thank you

@amrbashir
Copy link
Member

Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example.

@Hacksore Hacksore force-pushed the feat/allow-sign-env-vars branch from 2b0507d to de6722d Compare December 12, 2023 00:49
@Hacksore
Copy link
Contributor Author

Hacksore commented Dec 12, 2023

@amrbashir i had to force push so you're commit is partially verified now, not sure if that's a big deal.

@amrbashir
Copy link
Member

That should be fine, thanks

@amrbashir amrbashir merged commit 803c3a7 into tauri-apps:dev Dec 12, 2023
@Hacksore Hacksore deleted the feat/allow-sign-env-vars branch December 12, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants