feat(cli): expose CLI signer flags as environment variables#8327
Merged
amrbashir merged 3 commits intotauri-apps:devfrom Dec 12, 2023
Merged
feat(cli): expose CLI signer flags as environment variables#8327amrbashir merged 3 commits intotauri-apps:devfrom
amrbashir merged 3 commits intotauri-apps:devfrom
Conversation
e957c6c to
70701f4
Compare
amrbashir
reviewed
Dec 11, 2023
amrbashir
approved these changes
Dec 11, 2023
Member
|
Thank you |
Member
|
Oh looks like you didn't sign your commits and I can't merge the PR unless they are signed. You need to setup commit signing, then you can sign past commit like this for example. |
2b0507d to
de6722d
Compare
Contributor
Author
|
@amrbashir i had to force push so you're commit is partially verified now, not sure if that's a big deal. |
Member
|
That should be fine, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
TAURI_PRIVATE_KEY_PASSWORD,TAURI_PRIVATE_KEY_PASSWORD, andTAURI_PRIVATE_KEYto make it easier to use the CLI in a CI environment.In theory we can then call this with all the vars set to create a signature.
Although I saw that this renames the vars https://github.com/tauri-apps/tauri/blob/dev/.changes/cli-env-vars.md
I'm assuming that's a v2 breaking change and I'm not sure if I should adopt those values for this PR.
Guidance from the core team is extremely appreciated. thanks!
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information