Skip to content

fix(bundler): unset NSISDIR and NSISCONFDIR when running makensis#8376

Merged
amrbashir merged 1 commit into1.xfrom
fix/bundler/nsisdir
Dec 12, 2023
Merged

fix(bundler): unset NSISDIR and NSISCONFDIR when running makensis#8376
amrbashir merged 1 commit into1.xfrom
fix/bundler/nsisdir

Conversation

@amrbashir
Copy link
Copy Markdown
Member

closes #8359

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner December 12, 2023 09:20
@amrbashir amrbashir merged commit 777ddf4 into 1.x Dec 12, 2023
@amrbashir amrbashir deleted the fix/bundler/nsisdir branch December 12, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants