Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed channel deserialisation in iOS #8386

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

guillemcordoba
Copy link
Contributor

@guillemcordoba guillemcordoba commented Dec 13, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Without this, a registerListener command would fail with the following error: missing userInfo for Channel handler. This is a Tauri issue.

I think I've done everything required to make this PR, let me know if I'm missing something.

@guillemcordoba guillemcordoba requested a review from a team as a code owner December 13, 2023 13:04
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@lucasfernog lucasfernog merged commit 5848b4e into tauri-apps:dev Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants