Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api): generate types next to modules #8392

Merged
merged 3 commits into from
Dec 14, 2023
Merged

refactor(api): generate types next to modules #8392

merged 3 commits into from
Dec 14, 2023

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Dec 13, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir
refactor(api): generate types next to modules"
2529d16 
this fixes an issue with `moduleResolution: node`
@amrbashir amrbashir requested a review from a team as a code owner December 13, 2023 17:52
@amrbashir amrbashir changed the title refactor(api): generate types next to modules" refactor(api): generate types next to modules Dec 13, 2023
@lucasfernog lucasfernog merged commit 1c582a9 into 1.x Dec 14, 2023
8 checks passed
@lucasfernog lucasfernog deleted the refactor/api/types-next-to-modules branch December 14, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @lucasfernog