fix(runtime-wry): propagate wry file drop event to tao event loop, closes #8206#8393
Merged
lucasfernog merged 4 commits intodevfrom Dec 28, 2023
Merged
Conversation
amrbashir
changed the title
lucasfernog
approved these changes
Dec 28, 2023
lucasfernog
requested changes
Dec 28, 2023
| window_id, | ||
| WebviewMessage::WebviewEvent(WebviewEvent::FileDrop(event)), | ||
| )); | ||
| let has_listeners = !window_event_listeners.lock().unwrap().is_empty(); |
Member
There was a problem hiding this comment.
I think we should always return true now, we can't know for sure if the event was handled or not (that was the case with the previous implementation too - which is also wrong on v1)
Member
There was a problem hiding this comment.
unless... we add a new API (I'll take a look)
Member
Author
There was a problem hiding this comment.
An API would be nicer indeed
Member
There was a problem hiding this comment.
as I suspected we can't really determine this unless we create a closure just to handle the file drop event, and remove it from the event loop event enum. yikes. I think we should always block the default OS behavior instead.
lucasfernog
reviewed
Dec 28, 2023
lucasfernog
approved these changes
Dec 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information