Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): set CORS headers on protocol errors #8419

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This ensures the frontend can read the error message instead of just showing a CORS error

This ensures the frontend can read the error message instead of just showing a CORS error
@lucasfernog lucasfernog requested a review from a team as a code owner December 16, 2023 19:42
@lucasfernog lucasfernog merged commit 11a1529 into dev Dec 18, 2023
@lucasfernog lucasfernog deleted the fix/protocol-response branch December 18, 2023 23:54
@czf0613
Copy link

czf0613 commented Dec 20, 2023

Good job, I met the same problem and I got the same idea as you did.
How about merge this change into Tauri 1.x? I really need this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants