refactor!: remove GlobalWindowEvent type#8430
Merged
lucasfernog merged 2 commits intodevfrom Dec 19, 2023
Merged
Conversation
FabianLars
approved these changes
Dec 19, 2023
lucasfernog
approved these changes
Dec 19, 2023
lucasfernog
deleted the
refactor/core/remove-global-window-event-type
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This type was useless IMO and wasn't consistent with other callbacks. By unpacking its fields to be passed directly we make it consistent with other callbacks like
on_page_load