-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: import official webview rust binding #846
Conversation
🎉 🔥 🚀 💯 |
Types with Send usually have Sync too.
I could only verify the rust part, but it's good to merge imho. After this, I think we could open some refactor issues like |
I think binding functions (and maybe exposing that API to users) is going to have to wait, because Edge reloads the app and the But if you think the Rust part is OK then LGTM |
@wusyong are you ok with the change file I've added? |
Of course! 😄 |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch and not thelatest
branchfix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: