Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: import official webview rust binding #846

Merged
merged 13 commits into from
Jul 18, 2020
Merged

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Jul 17, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the latest branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@nothingismagick
Copy link
Sponsor Member

🎉 🔥 🚀 💯

@wusyong wusyong marked this pull request as ready for review July 18, 2020 01:20
@wusyong wusyong requested review from a team July 18, 2020 01:20
Types with Send usually have Sync too.
@wusyong
Copy link
Member Author

wusyong commented Jul 18, 2020

I could only verify the rust part, but it's good to merge imho. After this, I think we could open some refactor issues like Content type conversion, __initialized bindings and maybe others.

@lucasfernog
Copy link
Member

I think binding functions (and maybe exposing that API to users) is going to have to wait, because Edge reloads the app and the window[name] bindings are gone. (I had to manually set the INVOKE binding every time on JS, but it's just a workaround; talked about it on the webview Discord channel and I might open an issue).

But if you think the Rust part is OK then LGTM

@wusyong wusyong requested a review from a team as a code owner July 18, 2020 03:36
@lucasfernog
Copy link
Member

@wusyong are you ok with the change file I've added?

@wusyong
Copy link
Member Author

wusyong commented Jul 18, 2020

Of course! 😄

@lucasfernog lucasfernog merged commit cd5b401 into dev Jul 18, 2020
@lucasfernog lucasfernog deleted the feat/webview_rust branch July 18, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants