Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli) rewrite the core CLI in Rust #851

Merged
merged 67 commits into from
Jan 30, 2021
Merged

feat(cli) rewrite the core CLI in Rust #851

merged 67 commits into from
Jan 30, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the latest branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog
Copy link
Member Author

This PR is almost ready, just need to implement the old dev and build JS API for the commands (used by the unit tests and the vue-cli plugin).

@lucasfernog lucasfernog marked this pull request as ready for review January 29, 2021 23:53
@lucasfernog lucasfernog requested a review from a team as a code owner January 29, 2021 23:53
@lucasfernog lucasfernog requested review from a team January 29, 2021 23:53
@lucasfernog lucasfernog merged commit 3e8abe3 into dev Jan 30, 2021
@lucasfernog lucasfernog deleted the feat/rust-cli branch January 30, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants