fix(cli): Watch workspace members if tauri dir is workspace root #8520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See title. This PR also includes a fix/workaround for paths with funny characters that may not make the glob expansion panic. Fixes #8509
|
thinking about it i'm not sure anymore if it actually made a difference since it should watch the workspace members anyway since they are inside the root (if tauri dir is ws root) but ig being mroe explicit about it is good? 🙃 |
amrbashir
requested changes
Jan 2, 2024
amrbashir
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title. This PR also includes a fix/workaround for paths with funny characters that may not make the glob expansion panic.
Fixes #8509 -> That's about the funny characters and the reason i looked into the code again in the first place.