Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api.js): mock __TAURI_INTERNALS__ in mockIPC and mockWindows #8534

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

FabianLars
Copy link
Member

@FabianLars FabianLars requested a review from a team as a code owner January 3, 2024 16:12
@FabianLars FabianLars marked this pull request as draft January 3, 2024 17:59
@FabianLars FabianLars marked this pull request as ready for review January 3, 2024 19:05
@FabianLars
Copy link
Member Author

FabianLars commented Jan 3, 2024

I'm really insecure about the second commit. I feel like i'm missing something obvious here.

The first commit was to fix Cannot set properties of undefined (setting 'ipc')
The second commit was to fix window.__TAURI_INTERNALS__.invoke is not a function

So please feel free to rip me the PR apart :)

@amrbashir amrbashir merged commit 97e3341 into dev Jan 3, 2024
11 checks passed
@amrbashir amrbashir deleted the fix/mock-internal branch January 3, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants