fix(core): Command::output suspend while wait for response#8539
Merged
lucasfernog merged 3 commits intotauri-apps:1.xfrom Feb 1, 2024
Merged
fix(core): Command::output suspend while wait for response#8539lucasfernog merged 3 commits intotauri-apps:1.xfrom
lucasfernog merged 3 commits intotauri-apps:1.xfrom
Conversation
Contributor
Author
|
Maybe resolves #8572 |
lucasfernog
added a commit
to tauri-apps/plugins-workspace
that referenced
this pull request
Jan 31, 2024
amrbashir
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tauri/core/tauri/src/api/process/command.rs
Lines 273 to 286 in 67d7877
These two methods will hold the
tx(Sender)and never drop them because the methodspawn_pipe_readerwill be lost in the loop and unable to get out withoutbreak;tauri/core/tauri/src/api/process/command.rs
Lines 401 to 425 in 67d7877
So, the loop in
outputmethod will never receive aNonevalue fromReciver.tauri/core/tauri/src/api/process/command.rs
Lines 362 to 377 in 67d7877