Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor parent APIs on WindowBuilder #8622

Merged
merged 19 commits into from
Jan 31, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jan 17, 2024

closes #8587 #1643

  • Add .parent a convenient method on all platforms
  • Rename existing .parent_window to parent_raw
  • Add .transient_for and .transient_for_raw on Linux
  • Add parent field in tauri config and when creating window in JS

@amrbashir amrbashir requested a review from a team as a code owner January 17, 2024 02:52
@amrbashir
Copy link
Member Author

amrbashir commented Jan 17, 2024

Maybe a todo:

  • An option for parent in JS window creation
  • An option for parent in tauri config

@lucasfernog lucasfernog merged commit 9eaeb5a into dev Jan 31, 2024
31 checks passed
@lucasfernog lucasfernog deleted the refactor/parent-windows branch January 31, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please add child window support for linux platform [feat]
2 participants