fix: improvements and ipc fixes for loading window content using custom protocol#8670
Conversation
…om protocol closes #5478
3686caf to
3848838
Compare
| // TODO: what use-case is covered by this? | ||
| || (cfg!(dev) && current_url.domain() == Some("tauri.localhost")) |
There was a problem hiding this comment.
@lucasfernog what use-case is being covered by this check?
There was a problem hiding this comment.
IIRC it's for mobile.. should've documented it my bad
There was a problem hiding this comment.
won't this be covered by the tauri::// case as well?
|
There is one more improvement we can make but don't know if it makes sense? currently users will need to always explicitly specify the url for each window either in code or in tauri.conf.json, would it make sense if we allowed them to set a base url for all windows instead of |
I think this would complicate the codebase and introduce some bugs likely.. let's keep that until someone actually requests it |
|
I agree |
closes #5478
distDiranddevPathoptional so if someone wants to load all their windows using custom protocols they don't need to specify and create an empty directory fordistDirwhen buildingWebviewUrl::CustomProtocolwhich is the same asWebviewUrl::Externalbut more explicit.