fix(cli): add MaybeWorkspace to license field#8672
Merged
Conversation
Member
|
Thanks for contributing! Could you also add a changefile similar to https://github.com/tauri-apps/tauri/blob/dev/.changes/cli-config-target-mobile.md please? |
Contributor
Author
|
@FabianLars Added, hope my phrasing is correct here. |
FabianLars
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got the bug in a project after updating to latest v2-alpha.
And got this error:
From what I saw in a code, license field was expected to be either String or None, but not workspace. Made it same as other fields (by copy-pasting code from them).
I think that it should work with any other case, but at least it fixes my issue. Let me know if I made something wrong. Will try to be fast with responses.
Checks
cargo testpassescargo clippypassescargo fmtlocally passescargo installand used viacargo tauri devwith a license field likelicense = { workspace = true }, exception is not being thrown